[radvd-devel-l] [PATCH] Add support for NEMO Basic

Pekka Savola pekkas at netcore.fi
Tue Sep 27 06:02:03 EDT 2005


On Tue, 27 Sep 2005, Ville Nuorvala wrote:
> this incremental patch to the two previous ones allows radvd to set the 
> Mobile Router Support Flag defined in the NEMO Basic Support Protocol RFC.

I committed the two previous ones, thanks.

I'm a bit troubled by this:

+#ifndef ND_OPT_HAI_FLAG_SUPPORT_MR
+#if BYTE_ORDER == BIG_ENDIAN
+#define ND_OPT_HAI_FLAG_SUPPORT_MR     0x8000
+#else /* BYTE_ORDER == LITTLE_ENDIAN */
+#define ND_OPT_HAI_FLAG_SUPPORT_MR     0x0080
+#endif
+#endif

.. the code we're using right now doesn't need to make distinction 
between BE and LE (or maybe certain features just don't work :). 
Would designing this so that making one isn't needed be feasible?

-- 
Pekka Savola                 "You each name yourselves king, yet the
Netcore Oy                    kingdom bleeds."
Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings



More information about the radvd-devel-l mailing list