[radvd-devel-l] code cleaning

Reuben Hawkins reubenhwk at gmail.com
Fri Dec 10 21:38:06 EST 2010


On Fri, Dec 10, 2010 at 1:08 PM, Reuben Hawkins <reubenhwk at gmail.com> wrote:
> The attached script make a few cosmetic changes to the code...
>
> It changes the local headers files from using angle brackets to quotes
> (it is possible to pickup somebody else's config.h with angle brackets
> if they unknowingly install it)..
>  #include <radvd.h>  ->  #include "radvd.h"
>  #include <includes.h>  ->  #include "includes.h"
>  #include <pathnames.h>  ->  #include "pathnames.h"
>  #include <defaults.h>  ->  #include "defaults.h"
> It removes trailing whitespaces at the ends of the lines (they
> sometimes show up in diffs or merges and they're really annoying)
> It also adds gram.c gram.h scanner.c to CLEANFILES in Makefile.am (if
> we're going to rebuild, why not also regenerate the parser files too?)
>

Correction.  This script does what I claimed it did in my last email
for code cleanup...  I inadvertently left in a line which changed all
the   #ifdef HAVE_*  to  #if HAVE_* which is not needed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup2.sh
Type: application/x-sh
Size: 670 bytes
Desc: not available
URL: <http://lists.litech.org/pipermail/radvd-devel-l/attachments/20101210/f1144ae2/attachment.sh>


More information about the radvd-devel-l mailing list